ROS2 port of feature to report stale when no errors but stale items #9
Conversation
MCFurry
changed the title
MCFurry
changed the title
|
Not sure why rolling is failing, compiles fine locally in a rolling docker... |
|
Isn't this the same as: ros#315 |
|
Not sure why rolling is failing, compiles fine locally in a rolling docker...
Nope, that PR specifically targets discard analyzers. This PR makes sure that a stale diagnostic makes the toplevel output stale instead of error. |
Can rebase the That might fix the CI as well would be my guess. |
That would be a good idea indeed! |
|
Syncing done, let's see what the CI says now |
| @@ -256,6 +259,7 @@ void Aggregator::publishData() | |||
| diag_toplevel_state.values = msg_to_report->values; | |||
| } | |||
|
|
|||
| non_ok_status_depth = 0; | |||
| @@ -221,7 +221,7 @@ void Aggregator::publishData() | |||
| diag_toplevel_state.name = "toplevel_state"; | |||
| diag_toplevel_state.level = DiagnosticStatus::STALE; | |||
| int max_level = -1; | |||
| int min_level = 255; | |||
| int8_t max_level_without_stale = 0; | |||
| int non_ok_status_depth = 0; | |||
There was a problem hiding this comment.
@Rayman it is here already and simply reset on line 262.
ROS2 port of: https://github.com/nobleo/diagnostics/pull/2/files